refactor

tests/test_service_packages.py

@@ -1,5 +1,7 @@
 """Tests for PackageService."""
 
+import io
+import tarfile
 from pathlib import Path
 
 import pytest
@@ -63,3 +65,68 @@ class TestPackageService:
         svc = PackageService(ctx)
         with pytest.raises(FlowError, match="Specify"):
             svc.install()
+
+    def test_list_all_known_packages(self, tmp_path, monkeypatch, capsys):
+        monkeypatch.setattr(paths, "INSTALLED_STATE", tmp_path / "installed.json")
+        manifest = {"packages": [{"name": "fd", "type": "pkg"}]}
+        ctx = _make_ctx(tmp_path, manifest)
+        svc = PackageService(ctx)
+        svc.list_packages(show_all=True)
+        assert "fd" in capsys.readouterr().out
+
+    def test_install_binary_honors_declared_install_map(self, tmp_path, monkeypatch):
+        home = tmp_path / "home"
+        home.mkdir()
+        monkeypatch.setenv("HOME", str(home))
+        monkeypatch.setattr(paths, "DATA_DIR", tmp_path / "data")
+        monkeypatch.setattr(paths, "INSTALLED_STATE", tmp_path / "installed.json")
+
+        archive = io.BytesIO()
+        with tarfile.open(fileobj=archive, mode="w:gz") as tar:
+            files = {
+                "nvim-linux64/bin/nvim": b"#!/bin/sh\n",
+                "nvim-linux64/share/nvim/runtime.txt": b"runtime\n",
+                "nvim-linux64/share/man/man1/nvim.1": b"manpage\n",
+            }
+            for name, content in files.items():
+                info = tarfile.TarInfo(name=name)
+                info.size = len(content)
+                tar.addfile(info, io.BytesIO(content))
+        archive_bytes = archive.getvalue()
+
+        class FakeResponse:
+            def __enter__(self):
+                return self
+
+            def __exit__(self, exc_type, exc, tb):
+                return False
+
+            def read(self):
+                return archive_bytes
+
+        monkeypatch.setattr("flow.services.packages.urllib.request.urlopen", lambda *args, **kwargs: FakeResponse())
+
+        manifest = {
+            "packages": [{
+                "name": "neovim",
+                "type": "binary",
+                "source": "github:neovim/neovim",
+                "version": "0.10.4",
+                "asset-pattern": "nvim-{{os}}-{{arch}}.tar.gz",
+                "platform-map": {"linux-x64": {"os": "linux", "arch": "x64"}},
+                "extract-dir": "nvim-{{os}}64",
+                "install": {
+                    "bin": ["bin/nvim"],
+                    "share": ["share/nvim"],
+                    "man": ["share/man/man1/nvim.1"],
+                },
+            }],
+        }
+        ctx = _make_ctx(tmp_path, manifest)
+        svc = PackageService(ctx)
+        packages = svc.resolve_install_packages(package_names=["neovim"])
+        svc.install(packages)
+
+        assert (home / ".local" / "bin" / "nvim").exists()
+        assert (home / ".local" / "share" / "nvim" / "runtime.txt").exists()
+        assert (home / ".local" / "share" / "man" / "man1" / "nvim.1").exists()