Tomas Mirchev
a71742afee
Fail loud at the boundary:
- substitute_template raises ConfigError on unresolved {{...}}; no more
silent literal placeholders in download URLs.
- parse_profile raises ConfigError when 'os' is missing -- no
raw.get("os", "linux") default that silently masks typos.
- urllib download failures wrapped to FlowError.
- bootstrap _execute_action dispatches phases explicitly and raises
on unhandled phase; no more "anything else runs as shell".
Direct access over defensive wrapping:
- plan_bootstrap requires env; plan_install requires pm. Drop the
dead `or os.environ` / `or detect_package_manager()` fallbacks.
- InstalledState.from_dict raises ConfigError on missing fields
rather than .get(..., default).
- Replace `x or {}` chains with explicit `x if x is not None else {}`
in package resolution; catalog validates type/platform-map/install
shapes at parse.
One canonical form / direct access:
- Path.home() replaced with paths.HOME in services/packages.py and
commands/completion.py. paths.HOME is the single source now.
- Use Path.is_relative_to for install-path containment instead of
str.startswith.
Domain purity:
- domain/containers/resolution.resolve_mounts takes a filesystem_check
predicate; service passes the probe in. Domain no longer touches
the filesystem directly.
No speculative abstraction:
- Drop the `allow_sudo` field entirely. The _script_uses_sudo check
it gated was bypassable (substring match) and gave false confidence;
the manifest is fully user-trusted anyway.
- Delete dead terminfo_fix_command + RemoteService.fix_terminfo
(no command surface exposes them).
- FileSystem.remove_tree no longer swallows errors via ignore_errors;
callers opt into missing_ok if needed.
Typed enums:
- PackageDef.type, AppConfig.container_runtime as Literal[...].
container_runtime values validated at config parse.
Completion bypasses runtime no longer:
- complete(ctx, ...) threads context; ContainerRuntime and state-file
reads go through ctx.runtime instead of constructing primitives.
Tests added for: template raise, missing os raise, env/pm required,
unknown phase raise, no allow_sudo gate, URL download failure, install
path escape, corrupt installed.json, container_runtime Literal,
filesystem_check controls mounts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
68 lines
2.0 KiB
Python
68 lines
2.0 KiB
Python
"""Tests for packages domain models."""
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from flow.core.errors import ConfigError
|
|
from flow.domain.packages.models import InstalledPackage, InstalledState, PackageDef
|
|
|
|
|
|
def test_installed_state_roundtrip():
|
|
state = InstalledState(packages={
|
|
"neovim": InstalledPackage(
|
|
name="neovim", version="0.10.4", type="binary",
|
|
files=[Path("/home/x/.local/bin/nvim")],
|
|
),
|
|
})
|
|
data = state.as_dict()
|
|
restored = InstalledState.from_dict(data)
|
|
assert "neovim" in restored.packages
|
|
assert restored.packages["neovim"].version == "0.10.4"
|
|
assert restored.packages["neovim"].files == [Path("/home/x/.local/bin/nvim")]
|
|
|
|
|
|
def test_installed_state_empty():
|
|
state = InstalledState.from_dict({})
|
|
assert state.packages == {}
|
|
|
|
|
|
def test_installed_state_version_mismatch():
|
|
with pytest.raises(ConfigError):
|
|
InstalledState.from_dict({"version": 99, "packages": {}})
|
|
|
|
|
|
def test_installed_state_corrupt_missing_version_raises():
|
|
with pytest.raises(ConfigError, match="missing field 'version'"):
|
|
InstalledState.from_dict({
|
|
"version": 1,
|
|
"packages": {"fd": {"type": "pkg", "files": []}},
|
|
})
|
|
|
|
|
|
def test_installed_state_corrupt_missing_type_raises():
|
|
with pytest.raises(ConfigError, match="missing field 'type'"):
|
|
InstalledState.from_dict({
|
|
"version": 1,
|
|
"packages": {"fd": {"version": "1.0", "files": []}},
|
|
})
|
|
|
|
|
|
def test_installed_state_corrupt_missing_files_raises():
|
|
with pytest.raises(ConfigError, match="missing field 'files'"):
|
|
InstalledState.from_dict({
|
|
"version": 1,
|
|
"packages": {"fd": {"version": "1.0", "type": "pkg"}},
|
|
})
|
|
|
|
|
|
def test_package_def_fields():
|
|
pkg = PackageDef(
|
|
name="fd", type="pkg", sources={"apt": "fd-find"},
|
|
source=None, version=None, asset_pattern=None,
|
|
platform_map={}, extract_dir=None, install={},
|
|
post_install=None,
|
|
)
|
|
assert pkg.name == "fd"
|
|
assert pkg.type == "pkg"
|