Tomas Mirchev
a71742afee
Fail loud at the boundary:
- substitute_template raises ConfigError on unresolved {{...}}; no more
silent literal placeholders in download URLs.
- parse_profile raises ConfigError when 'os' is missing -- no
raw.get("os", "linux") default that silently masks typos.
- urllib download failures wrapped to FlowError.
- bootstrap _execute_action dispatches phases explicitly and raises
on unhandled phase; no more "anything else runs as shell".
Direct access over defensive wrapping:
- plan_bootstrap requires env; plan_install requires pm. Drop the
dead `or os.environ` / `or detect_package_manager()` fallbacks.
- InstalledState.from_dict raises ConfigError on missing fields
rather than .get(..., default).
- Replace `x or {}` chains with explicit `x if x is not None else {}`
in package resolution; catalog validates type/platform-map/install
shapes at parse.
One canonical form / direct access:
- Path.home() replaced with paths.HOME in services/packages.py and
commands/completion.py. paths.HOME is the single source now.
- Use Path.is_relative_to for install-path containment instead of
str.startswith.
Domain purity:
- domain/containers/resolution.resolve_mounts takes a filesystem_check
predicate; service passes the probe in. Domain no longer touches
the filesystem directly.
No speculative abstraction:
- Drop the `allow_sudo` field entirely. The _script_uses_sudo check
it gated was bypassable (substring match) and gave false confidence;
the manifest is fully user-trusted anyway.
- Delete dead terminfo_fix_command + RemoteService.fix_terminfo
(no command surface exposes them).
- FileSystem.remove_tree no longer swallows errors via ignore_errors;
callers opt into missing_ok if needed.
Typed enums:
- PackageDef.type, AppConfig.container_runtime as Literal[...].
container_runtime values validated at config parse.
Completion bypasses runtime no longer:
- complete(ctx, ...) threads context; ContainerRuntime and state-file
reads go through ctx.runtime instead of constructing primitives.
Tests added for: template raise, missing os raise, env/pm required,
unknown phase raise, no allow_sudo gate, URL download failure, install
path escape, corrupt installed.json, container_runtime Literal,
filesystem_check controls mounts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
86 lines
2.8 KiB
Python
86 lines
2.8 KiB
Python
"""Tests for remote domain."""
|
|
|
|
import pytest
|
|
|
|
from flow.core.config import TargetConfig
|
|
from flow.core.errors import FlowError
|
|
from flow.domain.remote.models import SSHCommand, Target
|
|
from flow.domain.remote.resolution import (
|
|
build_ssh_command,
|
|
list_targets,
|
|
parse_target,
|
|
resolve_target,
|
|
)
|
|
|
|
|
|
class TestParseTarget:
|
|
def test_valid_spec(self):
|
|
user, ns, plat = parse_target("personal@orb")
|
|
assert user is None
|
|
assert ns == "personal"
|
|
assert plat == "orb"
|
|
|
|
def test_valid_spec_with_user(self):
|
|
user, ns, plat = parse_target("alice@personal@orb")
|
|
assert user == "alice"
|
|
assert ns == "personal"
|
|
assert plat == "orb"
|
|
|
|
def test_missing_at_raises(self):
|
|
with pytest.raises(FlowError):
|
|
parse_target("invalid")
|
|
|
|
def test_empty_parts_raises(self):
|
|
with pytest.raises(FlowError):
|
|
parse_target("@orb")
|
|
|
|
|
|
class TestResolveTarget:
|
|
def test_found(self):
|
|
targets = [TargetConfig(namespace="personal", platform="orb", host="personal.orb")]
|
|
result = resolve_target("personal@orb", targets, default_user="tomas")
|
|
assert result.host == "personal.orb"
|
|
assert result.label == "personal@orb"
|
|
assert result.user == "tomas"
|
|
|
|
def test_not_found(self):
|
|
with pytest.raises(FlowError, match="Unknown target"):
|
|
resolve_target("missing@host", [], default_user="tomas")
|
|
|
|
def test_falls_back_to_host_template(self):
|
|
result = resolve_target("personal@orb", [], default_user="tomas")
|
|
assert result.host == "personal.orb"
|
|
|
|
|
|
class TestBuildSSHCommand:
|
|
def test_basic(self):
|
|
target = Target(namespace="personal", platform="orb", host="personal.orb", user="tomas")
|
|
cmd = build_ssh_command(target)
|
|
assert "ssh" in cmd.argv
|
|
assert cmd.destination == "tomas@personal.orb"
|
|
assert cmd.env["DF_NAMESPACE"] == "personal"
|
|
assert "tmux" in cmd.argv
|
|
|
|
def test_with_identity(self):
|
|
target = Target(namespace="work", platform="ec2", host="work.ec2", identity="~/.ssh/id_work", user="tomas")
|
|
cmd = build_ssh_command(target)
|
|
assert "-i" in cmd.argv
|
|
assert "~/.ssh/id_work" in cmd.argv
|
|
|
|
def test_without_tmux(self):
|
|
target = Target(namespace="p", platform="o", host="h", user="tomas")
|
|
cmd = build_ssh_command(target, no_tmux=True)
|
|
assert "tmux" not in cmd.argv
|
|
assert cmd.destination == "tomas@h"
|
|
|
|
|
|
class TestListTargets:
|
|
def test_converts_configs(self):
|
|
configs = [
|
|
TargetConfig(namespace="a", platform="b", host="a.b"),
|
|
TargetConfig(namespace="c", platform="d", host="c.d"),
|
|
]
|
|
targets = list_targets(configs)
|
|
assert len(targets) == 2
|
|
assert targets[0].label == "a@b"
|