Tomas Mirchev
a71742afee
Fail loud at the boundary:
- substitute_template raises ConfigError on unresolved {{...}}; no more
silent literal placeholders in download URLs.
- parse_profile raises ConfigError when 'os' is missing -- no
raw.get("os", "linux") default that silently masks typos.
- urllib download failures wrapped to FlowError.
- bootstrap _execute_action dispatches phases explicitly and raises
on unhandled phase; no more "anything else runs as shell".
Direct access over defensive wrapping:
- plan_bootstrap requires env; plan_install requires pm. Drop the
dead `or os.environ` / `or detect_package_manager()` fallbacks.
- InstalledState.from_dict raises ConfigError on missing fields
rather than .get(..., default).
- Replace `x or {}` chains with explicit `x if x is not None else {}`
in package resolution; catalog validates type/platform-map/install
shapes at parse.
One canonical form / direct access:
- Path.home() replaced with paths.HOME in services/packages.py and
commands/completion.py. paths.HOME is the single source now.
- Use Path.is_relative_to for install-path containment instead of
str.startswith.
Domain purity:
- domain/containers/resolution.resolve_mounts takes a filesystem_check
predicate; service passes the probe in. Domain no longer touches
the filesystem directly.
No speculative abstraction:
- Drop the `allow_sudo` field entirely. The _script_uses_sudo check
it gated was bypassable (substring match) and gave false confidence;
the manifest is fully user-trusted anyway.
- Delete dead terminfo_fix_command + RemoteService.fix_terminfo
(no command surface exposes them).
- FileSystem.remove_tree no longer swallows errors via ignore_errors;
callers opt into missing_ok if needed.
Typed enums:
- PackageDef.type, AppConfig.container_runtime as Literal[...].
container_runtime values validated at config parse.
Completion bypasses runtime no longer:
- complete(ctx, ...) threads context; ContainerRuntime and state-file
reads go through ctx.runtime instead of constructing primitives.
Tests added for: template raise, missing os raise, env/pm required,
unknown phase raise, no allow_sudo gate, URL download failure, install
path escape, corrupt installed.json, container_runtime Literal,
filesystem_check controls mounts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
58 lines
1.8 KiB
Python
58 lines
1.8 KiB
Python
"""Tests for RemoteService."""
|
|
|
|
import pytest
|
|
|
|
from flow.core.config import AppConfig, FlowContext, TargetConfig
|
|
from flow.core.console import Console
|
|
from flow.core.errors import FlowError
|
|
from flow.core.platform import PlatformInfo
|
|
from flow.core.runtime import SystemRuntime
|
|
from flow.services.remote import RemoteService
|
|
|
|
|
|
def _make_ctx(targets=None):
|
|
return FlowContext(
|
|
config=AppConfig(targets=targets or []),
|
|
manifest={},
|
|
platform=PlatformInfo(),
|
|
console=Console(color=False),
|
|
runtime=SystemRuntime(),
|
|
)
|
|
|
|
|
|
class TestRemoteService:
|
|
def test_enter_dry_run(self, capsys):
|
|
targets = [TargetConfig(namespace="personal", platform="orb", host="personal.orb")]
|
|
ctx = _make_ctx(targets)
|
|
svc = RemoteService(ctx)
|
|
svc.enter("personal@orb", dry_run=True)
|
|
output = capsys.readouterr().out
|
|
assert "personal@orb" in output
|
|
assert "ssh" in output
|
|
assert "tmux" in output
|
|
assert "DF_NAMESPACE=personal" in output
|
|
|
|
def test_enter_unknown_target(self):
|
|
ctx = _make_ctx()
|
|
svc = RemoteService(ctx)
|
|
with pytest.raises(FlowError, match="Unknown target"):
|
|
svc.enter("missing@host")
|
|
|
|
def test_list_targets(self, capsys):
|
|
targets = [
|
|
TargetConfig(namespace="personal", platform="orb", host="personal.orb"),
|
|
TargetConfig(namespace="work", platform="ec2", host="work.ec2"),
|
|
]
|
|
ctx = _make_ctx(targets)
|
|
svc = RemoteService(ctx)
|
|
svc.list()
|
|
output = capsys.readouterr().out
|
|
assert "personal@orb" in output
|
|
assert "work@ec2" in output
|
|
|
|
def test_list_empty(self, capsys):
|
|
ctx = _make_ctx()
|
|
svc = RemoteService(ctx)
|
|
svc.list()
|
|
assert "No targets" in capsys.readouterr().out
|