#1166 validate user's options (#1177)

lua/nvim-tree/actions/system-open.lua

@@ -9,7 +9,7 @@ local M = {
 }
 
 function M.fn(node)
-  if not M.config.system_open.cmd then
+  if #M.config.system_open.cmd == 0 then
     require("nvim-tree.utils").warn "Cannot open file with system application. Unrecognized platform."
     return
   end
@@ -53,7 +53,7 @@ end
 function M.setup(opts)
   M.config.system_open = opts or {}
 
-  if not M.config.system_open.cmd then
+  if #M.config.system_open.cmd == 0 then
     if M.config.is_windows then
       M.config.system_open = {
         cmd = "cmd",

lua/nvim-tree/legacy.lua

@@ -5,7 +5,7 @@ local M = {}
 -- TODO update git.io/JPhyt when adding a migration
 
 -- migrate the g: to o if the user has not specified that when calling setup
-local migrations = {
+local g_migrations = {
   nvim_tree_disable_netrw = function(o)
     if o.disable_netrw == nil then
       o.disable_netrw = vim.g.nvim_tree_disable_netrw ~= 0
@@ -178,22 +178,7 @@ local migrations = {
   end,
 }
 
-function M.migrate_legacy_options(opts)
-  local msg = nil
-
-  -- g: options
-  for g, m in pairs(migrations) do
-    if vim.fn.exists("g:" .. g) ~= 0 then
-      m(opts)
-      msg = (msg and msg .. ", " or "Following options were moved to setup, see git.io/JPhyt: ") .. g
-    end
-  end
-
-  if msg then
-    require("nvim-tree.utils").warn(msg)
-  end
-
-  -- regular opts
+local function refactored(opts)
   if opts.view then
     if opts.view.mappings then
       if opts.view.mappings.list then
@@ -207,4 +192,31 @@ function M.migrate_legacy_options(opts)
   end
 end
 
+local function removed(opts)
+  if opts.auto_close then
+    utils.warn "auto close feature has been removed, see note in the README (tips & reminder section)"
+    opts.auto_close = nil
+  end
+end
+
+function M.migrate_legacy_options(opts)
+  -- g: options
+  local msg
+  for g, m in pairs(g_migrations) do
+    if vim.fn.exists("g:" .. g) ~= 0 then
+      m(opts)
+      msg = (msg and msg .. ", " or "Following options were moved to setup, see git.io/JPhyt: ") .. g
+    end
+  end
+  if msg then
+    utils.warn(msg)
+  end
+
+  -- silently move
+  refactored(opts)
+
+  -- warn and delete
+  removed(opts)
+end
+
 return M