From eb856a50ca3eb90ae300fe9d7cb2fb42b6283d9b Mon Sep 17 00:00:00 2001
From: Alexander Courtis <alex@courtis.org>
Date: Sat, 25 Nov 2023 17:14:55 +1100
Subject: [PATCH] ci: shellcheck nits

---
 scripts/lls-check      | 5 +++--
 scripts/update-help.sh | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/lls-check b/scripts/lls-check
index 3aaaab23..7efe1421 100755
--- a/scripts/lls-check
+++ b/scripts/lls-check
@@ -21,11 +21,12 @@ if [ ! -d "${DIR_LLS}" ]; then
 fi
 
 # execute from within the lua-language-server directory as it expects specific file locations
-cd "${DIR_LLS}"
+cd "${DIR_LLS}" || exit
 OUT=$("${DIR_LLS}/bin/lua-language-server" --checklevel=Information --check "${DIR_SRC}" --logpath="${DIR_OUT}" --loglevel=error)
+RC=$?
+
 echo "${OUT}" >&2
 
-RC=$?
 if [ $RC -ne 0 ]; then
 	echo "failed with RC=$RC"
 	exit $RC
diff --git a/scripts/update-help.sh b/scripts/update-help.sh
index 522a5a44..b88de225 100755
--- a/scripts/update-help.sh
+++ b/scripts/update-help.sh
@@ -38,7 +38,7 @@ sed -i -e "/${begin}/,/${end}/{ /${begin}/{p; r /tmp/DEFAULT_ON_ATTACH.lua
 # help human
 echo > /tmp/DEFAULT_ON_ATTACH.help
 sed -E "s/^ *vim.keymap.set\('n', '(.*)',.*api(.*),.*opts\('(.*)'.*$/'\`\1\`' '\3' '|nvim-tree-api\2()|'/g
-" /tmp/DEFAULT_ON_ATTACH.lua | while read line
+" /tmp/DEFAULT_ON_ATTACH.lua | while read -r line
 do
 	eval "printf '%-17.17s %-26.26s %s\n' ${line}" >> /tmp/DEFAULT_ON_ATTACH.help
 done