Alexander Courtis
9b289abd69
revert( #3180 , #3177 ): invalid group or tabpage ( #3181 )
...
* Revert "feat(#2826 ): allow only one window with nvim-tree buffer per tab (#3174 )"
This reverts commit dd2364d680#2826 ): View tracks winids and bufnrs via events, unused for now (#3170 )"
This reverts commit 65bae44922#2826 ): remove view debug/cc, enable new codepaths for get_winid and get_bufnr (#3169 )"
This reverts commit a9156c0139
2025-08-10 11:18:31 +10:00
Alexander Courtis
a9156c0139
refactor( #2826 ): remove view debug/cc, enable new codepaths for get_winid and get_bufnr ( #3169 )
...
* refactor(#2826 ): fuller error messages
* refactor(#2826 ): winnr->winid in view/globals, remove redundant get_winid and get_bufnr calls
* refactor(#2826 ): winnr->winid consistently
* refactor(#2826 ): consistent use of buffer registry, tidy, add todos
* refactor(#2826 ): remove unnecessary view members float, hide_root_folder; use explorer opts
* refactor(#2826 ): remove unused view members centralize_selection and preserve_window_proportions
* refactor(#2826 ): remove unused view member height
* refactor(#2826 ): temporarily reuse BUFNR_PER_TAB in view constructor
* refactor(#2826 ): get_winid returns new after consistency check
* refactor(#2826 ): globals.TABPAGES -> WINID_PER_TAB
* refactor(#2826 ): consistent naming of tabid
* refactor(#2826 ): more consistency checking
* refactor(#2826 ): more consistency checking
* refactor(#2826 ): move global CURSORS to view member
* Revert "refactor(#2826 ): move global CURSORS to view member"
This reverts commit d84dfad1c3#2826 ): move global CURSORS to view member
* refactor(#2826 ): consistency check returns new
* refactor(#2826 ): remove consistency checks, enabling new path for view get_winid and get_bufnr
* refactor(#2826 ): restore CURSORS global
2025-07-28 12:44:17 +10:00
Alexander Courtis
0a06f65bf0
refactor( #2826 ): move view to instanced window class ( #3153 )
...
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class, WIP
* refactor(#2826 ): singleton View class
* refactor(#2826 ): View is an Explorer member
* refactor(#2826 ): move autocmds to Explorer
* refactor(#2826 ): API uses Explorer's View
* refactor(#2826 ): move View into Explorer package
* refactor(#2826 ): retain necessary view globals
* refactor(#2826 ): move all winhl to appearance constants
* refactor(#2826 ): add lifecycle logging to all Explorer members
* refactor(#2826 ): fix bad cherry-pick
* refactor(#2826 ): better enumerate_options function
* refactor(#2826 ): add View.tab_line for debugging
* refactor(#2826 ): default lifecycle log off
* refactor(#2826 ): add experimental.multi_instance_debug, split globals out of view, move diagnostics to its own module
* refactor(#2826 ): instrument View:get_winnr
* refactor(#2826 ): instrument View:setup_tabpage
* refactor(#2826 ): instrument View:set_current_win, View:prevent_buffer_override
* refactor(#2826 ): instrument View:get_bufnr
* refactor(#2826 ): track member bufnr -> winid with global
* refactor(#2826 ): tidy experiment names and logs
* vim: nvim-tree: track bufnr via buffer-update channel
* vim: nvim-tree: more logging
* vim: nvim-tree: revert: track bufnr via buffer-update channel
* refactor(#2826 ): notify error on view winid and bufnr mismatches
* refactor(#2826 ): notify error on view winid and bufnr mismatches
* refactor(#2826 ): explorer init logging
2025-06-19 15:45:55 +10:00
Lev Yuvenskiy
aae01853dd
fix( #3041 ): use vim.diagnostic.get for updating diagnostics ( #3042 )
...
* fix(#3041 ): use vim.diagnostic.get for updating diagnostics
* fix(#3041 ): remove unnecessary @type
---------
Co-authored-by: Alexander Courtis <alex@courtis.org>
2025-01-13 15:15:48 +11:00
Alexander Courtis
1f3ffd6af1
fix( #2954 ): more efficient LSP updates, increase diagnostics.debounce_delay from 50ms to 500ms ( #3007 )
...
* fix(#2954 ): use LSP diagnostic data deltas from events instead of a full query
* fix(#2954 ): use LSP diagnostic data deltas from events instead of a full query
2024-11-22 10:12:47 +11:00
des-b
28eac2801b
fix( #2990 ): Do not check if buffer is buflisted in diagnostics.update() ( #2998 )
...
This ensures that LSP diagnostics of files which are not manually opened
by users are rendered by nvim-tree diagnostic indicators.
However when users attach an LSP to nvim-tree this will bring back
flashing as attempted to fix in #2980 . Fixing this should probably done
by checking data passed via diagnostic events (DiagnosticChanged and
CocDiagnosticChanged).
Signed-off-by: des-b <66919647+des-b@users.noreply.github.com>
2024-11-11 08:57:06 +11:00
Alexander Courtis
610a1c189b
chore: resolve undefined-field warnings, fix link git statuses, rewrite devicons ( #2968 )
...
* add todo
* refactor(#2886 ): multi instance: node class refactoring: extract links, *_git_status (#2944 )
* extract DirectoryLinkNode and FileLinkNode, move Node methods to children
* temporarily move DirectoryNode methods into BaseNode for easier reviewing
* move mostly unchanged DirectoryNode methods back to BaseNode
* tidy
* git.git_status_file takes an array
* update git status of links
* luacheck hack
* safer git_status_dir
* refactor(#2886 ): multi instance: node class refactoring: DirectoryNode:expand_or_collapse (#2957 )
move expand_or_collapse to DirectoryNode
* refactor(#2886 ): multi instance: node group functions refactoring (#2959 )
* move last_group_node to DirectoryNode
* move add BaseNode:as and more doc
* revert parameter name changes
* revert parameter name changes
* add Class
* move group methods into DN
* tidy group methods
* tidy group methods
* tidy group methods
* tidy group methods
* parent is DirectoryNode
* tidy expand all
* BaseNode -> Node
* move watcher to DirectoryNode
* last_group_node is DirectoryNode only
* simplify create-file
* simplify parent
* simplify collapse-all
* simplify live-filter
* style
* move lib.get_cursor_position to Explorer
* move lib.get_node_at_cursor to Explorer
* move lib.get_nodes to Explorer
* move place_cursor_on_node to Explorer
* resolve resource leak in purge_all_state
* move many autocommands into Explorer
* post merge tidy
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* Revert "chore: resolve undefined-field"
This reverts commit be546ff18d41f28466b065c857e1e041659bd2c8.
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* chore: resolve undefined-field
* Revert "chore: resolve undefined-field"
This reverts commit e82db1c44d0e9b844d22
2024-11-03 14:06:12 +11:00
des-b
82ab19ebf7
fix( #2954 ): resolve occasional tree flashing on diagnostics, set tree buffer options in deterministic order ( #2980 )
...
* fix(#2954 ): set buffer options in deterministic order
This ensures related autocmd's (e.g. on FileType) will be called in a
similar environment.
* fix(#2954 ): redraw only for diagnostics if source buffer is 'buflisted'
is_buf_valid has been inlined since it is only used for diagnostics
and its name is misleading.
2024-11-02 12:07:42 +11:00
Alexander Courtis
1ae1c33ce1
chore( #2931 ): stylua -> EmmyLuaCodeStyle ( #2932 )
...
* stylua -> EmmyLuaCodeStyle: config and doc
* stylua -> EmmyLuaCodeStyle: CI
* stylua -> EmmyLuaCodeStyle: CI
* stylua -> EmmyLuaCodeStyle: CI
* stylua -> EmmyLuaCodeStyle: CI
* stylua -> EmmyLuaCodeStyle: CI
* stylua -> EmmyLuaCodeStyle
* stylua -> EmmyLuaCodeStyle: call_arg_parentheses = always
* stylua -> EmmyLuaCodeStyle
* stylua -> EmmyLuaCodeStyle
2024-09-29 14:05:52 +10:00
Alexander Courtis
03ae60313b
refactor( #2875 ): multi instance renderer ( #2900 )
...
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): deal with some cyclic require
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
* refactor(#2875 ): multi instance renderer
2024-09-21 10:41:35 +10:00
Alexander Courtis
8704b6f7fc
chore( #2787 ): minimum nvim version 0.9, replace 0.10 deprecated, enable deprecated warnings ( #2788 )
...
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): enable deprecated checks
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): use inline deprecation disabling
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): replace deprecated
* refactor(#2787 ): deprecated are now warnings
* refactor(#2787 ): 0.9 is the minimum supported version
* Revert "refactor(#2787 ): replace deprecated"
This reverts commit b6b4c32fcb#2787 ): suppress deprecated until 0.11
* refactor(#2787 ): minimum nvim version 0.8 -> 0.9
* refactor(#2787 ): reset globals
* refactor(#2787 ): explicitly check for vim.diagnostic.is_enabled function presence
2024-06-09 12:24:35 +10:00
Alexander Courtis
26632f496e
chore( #2731 ): neovim luadoc 0.10 compliance ( #2786 )
...
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings, type gymnastics
* refactor(#2731 ): resolve warnings, type gymnastics
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): handle cwd unavailable when opening
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings, type gymnastics
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): style
* refactor(#2731 ): add _meta library, explicit check disables
* refactor(#2731 ): add lua-language-server manual install instructions
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): explicitly set all diagnostics, reduce deprecated to hint
* Revert "refactor(#2731 ): resolve warnings"
This reverts commit 9c0526b7b0#2731 ): resolve warnings"
This reverts commit f534fbc606#2731 ): handle directory unavailable when deleting
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): handle directory unavailable when creating explorer
* refactor(#2731 ): add all nvim lua libraries
* refactor(#2731 ): resolve warnings
* refactor(#2731 ): remove vim global
* refactor(#2731 ): disable deprecated until we have a 0.9->0.10 story
2024-06-01 15:24:03 +10:00
Alexander Courtis
517e4fbb9e
revert( #2781 ): "refactor: replace deprecated use of vim.diagnostic.is_disabled()" ( #2784 )
...
Revert "refactor: replace deprecated use of vim.diagnostic.is_disabled() (#2781 )"
This reverts commit 4215f33da5
2024-05-26 11:34:03 +10:00
Zachary Rizer
4215f33da5
refactor: replace deprecated use of vim.diagnostic.is_disabled() ( #2781 )
...
* Deprecation fix
* Deprecation fix
* remove unnecessary assignment
---------
Co-authored-by: Alexander Courtis <alex@courtis.org>
2024-05-25 14:42:34 +10:00
Alexander Courtis
6a99f5af78
ci: lua language server and Makefile ( #2546 )
...
* ci: add lls-check
* ci: add lls-check to ci.yml
* ci: download lua-language-server binary
* ci: download lua-language-server binary
* ci: dummy failure to test
* Revert "ci: dummy failure to test"
This reverts commit 2bc43bad430209e32a5049a16c56710c4f6e2f7b.
* ci: ignore lls-out
* ci: better name
* ci: shellcheck nits
* ci: add luals libs and tidy
* ci: tidy
* ci: add neovim 0.9.4
* ci: add ci neovim 0.9.4 to lib path
* ci: dummy failure to test
* Revert "ci: dummy failure to test"
This reverts commit 45987335d81ec65fecc6636b339671a9a9fcdd97.
* Revert "ci: add ci neovim 0.9.4 to lib path"
This reverts commit 4f397d6ea8bbdf6e808f9dc9db5ecbae291d8cd4.
* Revert "ci: add neovim 0.9.4"
This reverts commit 46fd1b368d27a1892b55381691723db3b30a7527.
* ci: action downloads and installs luals
* ci: remove workspaces from luals
* ci: consistent script naming
* ci: add quality to contributing
* ci: consistent script naming
* ci: add lsp to diagnostics
* ci: temporary find to enumerate home
* ci: add VIMRUNTIME for lls
* ci: temporary find to enumerate home
* ci: temporary find to enumerate home
* ci: remove temporary find to enumerate home
* ci: correct VIMRUNTIME
* ci: add ${3rd}/luv/library
* ci: note VIMRUNTIME override
* ci: add Makefile
* ci: add Makefile
* ci: add Makefile
* ci: add Makefile
* ci: document checks and fixes
* ci: add help check
* ci: add help check
* ci: dummy help failure
* Revert "ci: dummy help failure"
This reverts commit c50cceaa4afcef6a11e9a8cb50d39d
2024-01-06 13:18:52 +11:00
Max
96a783fbd6
fix( #2519 ): Diagnostics Not Updated When Tree Not Visible ( #2597 )
...
* fix(#2519 ): diagnostics overhaul
Signed-off-by: iusmac <iusico.maxim@libero.it>
* fix: Properly filter diagnostics from coc
Also, while we're at it, refactor the lsp function for consistency.
There should be no functional change, just cosmetic.
Signed-off-by: iusmac <iusico.maxim@libero.it>
* Assign diagnostic version per node to reduce overhead
Signed-off-by: iusmac <iusico.maxim@libero.it>
* Require renderer once
Signed-off-by: iusmac <iusico.maxim@libero.it>
* Revert "Require renderer once"
Causes circular requires after the previous commit.
This reverts commit 7413041630
2023-12-30 14:30:07 +11:00
Azad
13f967f8e7
chore: add type annotations and resolve LSP warnings ( #2555 )
...
* chore: add type annotations to (almost) all functions
* stylua
* Add classes for symlink nodes
* Replace deprecated `@vararg`
* Move node classes to `node` module
* Fix `Symlink*` classes
* add vim and libuv runtime for luals, qualify libuv types
* add scripts/luals-check, not quite ready for CI
* additional nil checks for git/init.lua and git/runner.lua
* additional nil checks for nvim-tree.lua
* wrap vim.cmd-as-a-function calls inside functions
* vim.tbl_filter predicate returns booleans
* Revert "add scripts/luals-check, not quite ready for CI"
This reverts commit c70229cad9
2023-12-09 11:34:35 +11:00
Azad
4054fc4be3
refactor: format tables line by line for better readability ( #2456 )
...
* Format tables line by line for better readability
* Forgot a comma
---------
Co-authored-by: Alexander Courtis <alex@courtis.org>
2023-10-14 18:07:28 +11:00
Alexander Courtis
53b0bcaada
chore: stylua column width 120 -> 140 ( #2448 )
...
* chore: stylua column width 120 -> 140
* chore: stylua column width 120 -> 140, tidy
* Revert "chore: stylua column width 120 -> 140, tidy"
This reverts commit 8a0524d6bd
2023-10-08 11:40:58 +11:00
Alexander Courtis
323f65cb9c
feat( #1917 ): add diagnostic highlighting and icon placement ( #2396 )
...
* feat(#1917 ): add renderer.highlight_diagnostics
* feat(#1917 ): add renderer.highlight_diagnostics
* feat(#1917 ): add enderer.icons.diagnostics_placement
* feat(#1917 ): add renderer.icons.show.diagnostics
* feat(#1917 ): document highlight overrides
2023-09-03 12:29:33 +10:00
Steven Stallion
8d82c4dbe1
feat: support vim.diagnostic.is_disabled() ( #2232 )
...
Co-authored-by: Alexander Courtis <alex@courtis.org>
2023-06-10 16:10:28 +10:00
CsYakamoz
874b7be5d0
fix(diagnostics): coc obey diagnostics.severity ( #2072 )
...
`diagnostics.severity` option do not work with coc
2023-03-25 16:06:21 +11:00
Alexander Courtis
b712b82b0c
fix( #1961 ): harden profiling functions ( #1986 )
2023-02-11 17:05:01 +11:00
Alexander Courtis
fee6801393
fix(diagnostics): do not show on file/dir with same prefix
2022-12-23 12:44:30 +11:00
Richard Li
3000797e53
fix(diagnostics): do not show on file/dir with same prefix ( #1832 )
...
* fix diagnostics showing up on file/dir with same prefix
* using fnamemodify instead of gsub
2022-12-23 12:36:23 +11:00
Richard Li
829e9f68e1
feat: add diagnostics.show_on_open_dirs git.show_on_open_dirs ( #1778 )
...
* feat(diagnostics): only show diagnostic on closed folder
* feat(git): only show git icon on closed folder
2022-11-29 11:12:34 +11:00
Ibrahim Abdelkareem
68a2a0971e
feat(diagnostics): add diagnostics.severity ( #1755 )
...
* feat: Support diagnostics severity
* fix: Revert Hunk
* feat: Supports min/max severity
* feat: Supports min/max severity: tidy doc
* feat: Supports min/max severity: tidy doc
* feat: Supports min/max severity: tidy doc
Co-authored-by: Alexander Courtis <alex@courtis.org>
2022-11-21 09:09:09 +11:00
Alexander Courtis
8cc369695b
fix: replace vim.* "requires" with explicit calls to vim functions ( #1701 )
2022-11-06 10:37:33 +11:00
Alexander Courtis
06e48c29c4
chore(watchers): refactor events and make debouncer safe
...
- fs poll -> fs events
- make debouncer safe and fix diagnostics events
2022-07-17 08:50:24 +02:00
Alexander Courtis
80d4f28383
feat( #1245 ): add next_diag_item and prev_diag_item actions
2022-07-03 16:04:49 +10:00
Kiyan
e6c1b4cd5b
chore(setup): make setup idempotent ( #1340 )
...
Co-authored-by: Alexander Courtis <alex@courtis.org>
2022-06-26 12:14:03 +02:00
Alexander Courtis
0373680819
#1301 nvim uses LuaJIT 2.1 -> lua 5.1
2022-05-29 12:29:40 +10:00
Alexander Courtis
c3b7be8d19
add .luarc.json for lua-language-server and fix a couple of nits ( #1296 )
2022-05-28 11:16:54 +02:00
Kiyan
f8312cd06f
feat(renderer): add ability to set git icons in signcolumn ( #1242 )
2022-05-14 09:54:27 +02:00
Michael
46014449b6
refactor: use lua api for user commands and autocommands ( #1206 )
...
BREAKING: plugin now requires nvim-0.7
2022-05-14 09:49:45 +02:00
Alexander Courtis
82ec79aac5
#1216 show diagnostic signs on all folders ( #1244 )
2022-05-10 11:22:11 +10:00
Alexander Courtis
a448e66dde
#1216 respond to CocDiagnosticChange ( #1243 )
2022-05-08 11:41:20 +02:00
Kiyan
b1dfcabba1
chore(diagnostics): clear whole group instead of keeping a table ( #1241 )
2022-05-08 11:40:53 +02:00
kiyan
958bac90d2
chore: drop 0.5 support in diagnostics
2022-04-20 21:40:43 +02:00
Alexander Courtis
7629d4d106
#1091 diagnostics logging ( #1170 )
2022-04-18 15:39:51 +02:00
kiyan
3cf67c5849
fix: remove diagnostics in help view
...
fixes #1088
2022-03-19 12:32:11 +01:00
kiyan
471afc13fe
refacto: abstract TreeExplorer in core.lua
2022-03-09 22:01:54 +01:00
Kiyan
0816064a8b
chore: add stylua to format the codebase, and run on CI ( #1055 )
2022-03-06 17:33:30 +01:00
kiyan
5a6fd49ee5
fix: check bufnr is valid in diagnostics
2022-02-16 08:29:13 +01:00
kiyan
c584ac3509
fix: do not update diagnostics when tree is nil
...
fixes #984
fixes #981
2022-02-15 07:59:54 +01:00
Kiyan
6da7467944
refacto: buffer management, setup fixes, autocmd fixes ( #967 )
2022-02-14 19:16:45 +01:00
kiyan
ea92e7bf7c
refacto: set tree explorer in the global state
...
also remove the redraw method and use renderer.draw immediately
2022-02-07 22:07:08 +01:00
kiyan
4a9e53143b
refacto: ubiquitous language renaming
...
BREAKING
- rename all 'entry' to 'node' or '_node' if shadowing
- rename all 'entries' to 'nodes'
2022-02-05 18:10:09 +01:00
Reviakin Evgeny
239f2d6fea
show diagnostics on parent dirs if nodes with diagnostics are not visible ( #862 )
2021-12-24 12:47:23 +01:00
Jason Hansen
06a2b799c6
Fix for deprecated vim.lsp.diagnostic.get_all ( #840 )
2021-12-12 12:34:05 +01:00
